Skip to content

Conversation

tblah
Copy link
Contributor

@tblah tblah commented Jun 9, 2020

Adds a disabled docker image on which to run RISC-V tests. Based on the armhf image.

Test using

./src/ci/docker/run.sh riscv64gc-linux

cc: @msizanoen1

tblah added 2 commits June 9, 2020 16:22
This will run all tests for `riscv64gc-unknown-linux-gnu` in a QEMU
instance. This is based upon the armhf QEMU test image.
@rust-highfive
Copy link
Contributor

r? @pietroalbini

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 9, 2020
Thanks to jfrimmel for pointing this out

Co-authored-by: J. Frimmel <[email protected]>
@pietroalbini
Copy link
Member

This looks fine from a cursory glance. Thanks for sending the PR!

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 11, 2020

📌 Commit 086eaf8 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2020
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 20, 2020
RISC-V Emulated Testing

Adds a disabled docker image on which to run RISC-V tests. Based on the armhf image.

Test using
```
./src/ci/docker/run.sh riscv64gc-linux
```

cc: @msizanoen1
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 20, 2020
RISC-V Emulated Testing

Adds a disabled docker image on which to run RISC-V tests. Based on the armhf image.

Test using
```
./src/ci/docker/run.sh riscv64gc-linux
```

cc: @msizanoen1
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 20, 2020
RISC-V Emulated Testing

Adds a disabled docker image on which to run RISC-V tests. Based on the armhf image.

Test using
```
./src/ci/docker/run.sh riscv64gc-linux
```

cc: @msizanoen1
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 20, 2020
Rollup of 9 pull requests

Successful merges:

 - rust-lang#72600 (Properly encode AnonConst into crate metadata)
 - rust-lang#73055 (remove leftover mentions of `skol` and `int` from the compiler)
 - rust-lang#73058 (Support sanitizers on aarch64-unknown-linux-gnu)
 - rust-lang#73171 (RISC-V Emulated Testing)
 - rust-lang#73404 (Update CFGuard syntax)
 - rust-lang#73444 (ci: disable alt build during try builds)
 - rust-lang#73471 (Prevent attacker from manipulating FPU tag word used in SGX enclave)
 - rust-lang#73539 (Deprecate `Vec::remove_item`)
 - rust-lang#73543 (Clean up E0695 explanation)

Failed merges:

r? @ghost
make olddefconfig && \
make -j$(nproc) vmlinux
RUN cp linux-5.6.16/vmlinux /tmp
RUN rm -rf linux-5.6.16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use ... && make -j$(nproc) vmlinux && cp linux-5.6.16/vmlinux /tmp && rm -rf linux-5.6.16, the linux-5.6.16 dir will not become part of the dockee image. Every RUN command creates a new overlay on top of the image as of before the RUN command. It doesn't replace it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gentle ping @tblah

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjorn3 thanks for the reminder, I'll take a look

@bors bors merged commit 77efcab into rust-lang:master Jun 20, 2020
@cuviper cuviper added this to the 1.46 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants